playwright(book): let the tests pass on small screens #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Playwright tests want to verify that the translated book versions can be navigated to, they assumed that the links were visible, but that is only true on "big screens". On phones, for example, the sidebar button has to be pressed first. With this change, a manual `npx playwright test` passes again. Note: This was not caught by the CI runs because they only test with Chrome (to avoid hefty downloads of the Firefox, Chromium and Webkit browsers, only Chrome is tested because it comes pre-installed on GitHub's hosted Actions runners). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This let's manual
npx playwright testinvocations pass again.Context
When attempting to verify that #1891's deployment indeed fixed the iPhone issues, I noticed that the Playwright tests were failing in a totally unexpected location: The assumptions in the
booktests do not hold true for smaller screens. Easy fix.Note: This was not caught by the CI runs because they only test with Chrome (to avoid hefty downloads of the Firefox, Chromium and Webkit browsers, only Chrome is tested because it comes pre-installed on GitHub's hosted Actions runners).